search

JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

Legacy octal numbers #122

Open armano2 opened 5 years ago

armano2 commented 5 years ago

Right now we are converting raw value to number by calling parse function from js, but there is one syntax witch is allowed in nonstrict mode 0777

this is legacy way to do binary values, before 0b777 was added

right now we are setting value of node to 777 and we should set it to 511

armano2 commented 5 years ago

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Errors/Deprecated_octal

armano2 commented 5 years ago

while doing this we have to make sure that we support https://github.com/tc39/proposal-numeric-separator