search

JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

feat: fix issues with constructor method #124

Closed armano2 closed 5 years ago

armano2 commented 5 years ago
codecov[bot] commented 5 years ago

Codecov Report

Merging #124 into master will increase coverage by 0.22%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   93.49%   93.71%   +0.22%     
==========================================
  Files           8        8              
  Lines        1398     1401       +3     
  Branches      324      325       +1     
==========================================
+ Hits         1307     1313       +6     
+ Misses         50       49       -1     
+ Partials       41       39       -2
Impacted Files Coverage Δ
src/node-utils.ts 96.05% <100%> (+0.05%) :arrow_up:
src/convert.ts 94.46% <100%> (+0.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 131bdea...f803a16. Read the comment docs.

JamesHenry commented 5 years ago

Great, thanks!

JamesHenry commented 5 years ago

:tada: This PR is included in version 18.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

armano2 commented 5 years ago

did you read my comment?

JamesHenry commented 5 years ago

This one? https://github.com/JamesHenry/typescript-estree/pull/124#discussion_r247357883

armano2 commented 5 years ago

yes, i'm just unsure if we should follow them on this one