JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

fix: mark only leading string expressions as directives #126

Closed armano2 closed 5 years ago

armano2 commented 5 years ago

This PR fixes detection of directives:

codecov[bot] commented 5 years ago

Codecov Report

Merging #126 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   93.71%   93.71%           
=======================================
  Files           8        8           
  Lines        1401     1401           
  Branches      325      325           
=======================================
  Hits         1313     1313           
  Misses         49       49           
  Partials       39       39
Impacted Files Coverage Δ
src/convert.ts 94.46% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c53fc3...639b398. Read the comment docs.

armano2 commented 5 years ago

ohh, i see there is one more issue here

JamesHenry commented 5 years ago

@armano2 Please could you email me when you get chance: typescript-eslint@jameshenry.blog

armano2 commented 5 years ago

can't we just go on slack or discord, i don't like sharing my emails with strangers xd

JamesHenry commented 5 years ago

(redacted link) - we are both on spectrum now