JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

[Suggestion] Nightly builds #39

Open corbinu opened 5 years ago

corbinu commented 5 years ago

I was wondering if it would be possible to setup nightly builds? I am going to suggest this in typescript-eslint-parser also.

This would be really for use with the nightly typescript version and only for those that want to be on the bleeding edge. This would obviously only be valuable if typescript-eslint-parser is amenable.

I am happy to help!

j-f1 commented 5 years ago

The package could also add a prepare script that compiles the TS, and people could install JamesHenry/typescript-estree. npm will automatically install devDependencies when a package is installed from Git and the prepare script is present.

corbinu commented 5 years ago

@j-f1 A good idea but I do feel like that when a new version comes out (like 3.2 just did) I would have to maintain my own fork of typescript-eslint-parser (something I do do now) and then switch the package to that branch when it is created

JamesHenry commented 5 years ago

Wouldn’t you need that anyway for new features and/or breaking changes? E.g. bigint was just added and that would have been a parse error until our update went out, the nightly wouldn’t help you there right? On Sat, 1 Dec 2018 at 15:40, Corbin Uselton notifications@github.com wrote:

@j-f1 https://github.com/j-f1 A good idea but I do feel like that when a new version comes out (like 3.2 just did) I would have to maintain my own fork of typescript-eslint-parser (something I do do now) and then switch the package to that branch when it is created

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JamesHenry/typescript-estree/issues/39#issuecomment-443456813, or mute the thread https://github.com/notifications/unsubscribe-auth/AA29qw_W_ZbVdAEtLxY67d16ADoAPm0vks5u0ulCgaJpZM4Y8k1L .

corbinu commented 5 years ago

Well my thought is this would be targeting typescript nightly so BigInt could be merged onto a nightly branch as soon as it was ready. Then when 3.2 was released you would actually create the 3.2 PR out of the nightly branch features that had stabilized.

corbinu commented 5 years ago

Not at all trying to make more work for you though. Was hoping it could be totally automated and just thought it would a be a way for a subset of users to make PRs and see quick results while keeping the mainline releases stable. Especially given now we have 3 closely related products with separate teams.

armano2 commented 5 years ago

@JamesHenry @corbinu i'm refactoring types used in convert.ts, we are going to have type checking if AST from typescript didn't change. It's going to help with nightly builds :>