search

JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

chore: add editorconfig #49

Closed armano2 closed 5 years ago

armano2 commented 5 years ago

This PR adds editorconfig file

JamesHenry commented 5 years ago

Is this for cases where an editor doesn't support a prettier extension?

armano2 commented 5 years ago

yes, and editorconfig is used by github (in diff view and file viewer), github windows, and its build in to a lot of editors https://editorconfig.org/#download

JamesHenry commented 5 years ago

I don't really want to move away from prettier, I misunderstood this at first. When @j-f1 requested you remove .prettierrc I assumed that prettier must therefore support .editorconfig files as a source of config, but it doesn't seem like that's the case?

armano2 commented 5 years ago

this is a case, prettier is using .editorconfig

armano2 commented 5 years ago

and it used by default, you have to explicitly states to not use it in cli https://prettier.io/docs/en/cli.html#no-editorconfig https://prettier.io/docs/en/api.html#prettierresolveconfigfilepath-options

j-f1 commented 5 years ago

@JamesHenry no that’s correct — Prettier does support loading an editorconfig. This PR doesn’t move away from Prettier, it just converts the config to a more portable format.

JamesHenry commented 5 years ago

Ok cool, thanks!

JamesHenry commented 5 years ago

I'm about to board a 7 hour flight just FYI, so might suddenly drop off the grid :)

JamesHenry commented 5 years ago

:tada: This PR is included in version 7.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: