BREAKING: correct nodes TSConstructorType and TSConstructorType

[armano2]

This PR contains breaking changes and its alternative way of solving issue #30

Changes from this PR align structure of AST with what babel produces. There is alternative version of aligning those nodes #60

---

babel parses CallSignature and ConstructSignature as TSCallSignatureDeclaration and TSConstructSignatureDeclaration and has fields:

  interface foo {
    <P>(x: X): A
  }

• typeParameters typeParameters
• parameters array of all parameters
• typeAnnotation expected return type of function

right now we are parsing it as typeParameters, (params or parameters) and typeAnnotation

fixes: #30, #60

[armano2]

i'm unsure how we should proceed with this, do we want to have same structure as babel for this? or we want to align it to how names are provided in estree...

[JamesHenry]

Yeah it's a tricky one for sure. The inconsistency on the babel side makes me think that maybe we should forgo compatibility on this one for now and just make a clear note that we need to fix it up on the babel side later.

There have been plenty of cases over the last year or so that I flagged up or fixed odd things on the babel side after discovering them through the ast-alignment testing, so it is not entirely unexpected.

What do you think?

[armano2]

I'm OK with changing names of properties but I feel like we should keep type of node same as babel has

[JamesHenry]

Sounds good 👍

[armano2]

ok i'm closing than #60 and i will rebase change here

[JamesHenry]

:tada: This PR is included in version 11.0.0 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: