search

JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

feat: update TSFunctionType and TSConstructorType nodes #91

Closed armano2 closed 5 years ago

armano2 commented 5 years ago

This PR fixes range of TypeAnnotation in function type: before: > void after: => void

armano2 commented 5 years ago

I'm not shure if we should change name of paramerters here to as we did for other function like nodes, typeAnnotation and parameters to returnType and params

JamesHenry commented 5 years ago

Yeah, let's do that for now please

armano2 commented 5 years ago

should we also do this for other function like types?

like: TSConstructorType

type Constructor<T> = new (...args: any[]) => T;
armano2 commented 5 years ago

ohh, right this issue is going to be present in TSConstructorType to xd

armano2 commented 5 years ago

@JamesHenry can you review it once more? i fixed also issue with TSConstructorType

JamesHenry commented 5 years ago

:tada: This PR is included in version 13.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: