search

JamesIves / discord-wow-armory-bot

⚔️🗡️ World of Warcraft bot for Discord which checks a characters item level, notable achievements and pve/pvp progression and posts it in the chat.
https://jamesiv.es/python/2017/07/18/discord-wow-bot
MIT License
33 stars 25 forks source link

Tides of Vengeance #48

Closed JamesIves closed 5 years ago

JamesIves commented 5 years ago

Description

Provide a description of what your changes do.

This pull request introduces the upcoming raids Crucible of Storms and the Battle of Dazar'alor to the bot. You'll be able to see all of the raid kills from normal up to mythic including the AOTC and Cutting Edge achievements.

Testing Instructions

Give us step by step instructions on how to test your changes.

This cannot be merged until the Blizzard API supports these two raids. As they have both not been released this PR will remain pending until the data has been surfaced.

Additional Notes

Anything else that will help us test the pull request.

It would be nice in the future if I could make these updates and then only display the data once the API begins support, that way I can make updates in my own time and not have to worry about the API changing.

JamesIves commented 5 years ago

This needs to be split into multiple PR's as the raids don't release at the same time.