search

JamesLMilner / THREEAR

A marker based Augmented Reality library for Three.js
https://jameslmilner.github.io/THREEAR/
172 stars 24 forks source link

NFT support #84

Open nicolocarpignoli opened 5 years ago

nicolocarpignoli commented 5 years ago

Hi, I am the lead maintainer of AR.js, I saw your project time ago, great great job! I have a question: if you have time to give a look to this issue (https://github.com/jeromeetienne/AR.js/issues/544): it is an attempt to bring NFT feature on AR.js (but it can also, obviously, be brought to THIS library of yours) using the NFT branch of jsartoolkit. Such branch is outdated, but it seems to work some time ago.

What do you think about that? Did you have already done some experiments using other jsartoolkit version, like this one for example?

Thanks

JamesLMilner commented 5 years ago

Hi @nicolocarpignoli thanks for the issue. I haven't looked into this, as it was difficult enough getting things working and refactoring the codebase. If the NFT branch if artoolkit can be compiled correctly, I could look into adding it to the library in the future.

kalwalt commented 4 years ago

Hi @JamesLMilner we are merging the NFT feature into the master branch of jsartoolkit5 see this PR https://github.com/artoolkitx/jsartoolkit5/pull/86 and this PR https://github.com/kalwalt/jsartoolkit5/pull/1 on my repo. If you plan to add NFT into THREEAR and you need some help just ask, i will happy to support you.

JamesLMilner commented 4 years ago

@kalwalt that's super cool! One thing we'd need to do is compile a new version of jsartoolkit for the project and test that it doesn't break any of the current features. However this is a big ask and might be more than you fancy doing so I totally understand if not. After that it'd need to be exposed in the controller (https://github.com/JamesLMilner/THREEAR/blob/799d17c08416e49fbf6ee04da6d47e182124f991/src/artoolkit/ARToolKitController.ts) and then the library API (https://github.com/JamesLMilner/THREEAR/blob/master/src/Controller.ts and create a new marker type). Hope that makes sense!

kalwalt commented 4 years ago

@kalwalt that's super cool! One thing we'd need to do is compile a new version of jsartoolkit for the project and test that it doesn't break any of the current features. However this is a big ask and might be more than you fancy doing so I totally understand if not. After that it'd need to be exposed in the controller (https://github.com/JamesLMilner/THREEAR/blob/799d17c08416e49fbf6ee04da6d47e182124f991/src/artoolkit/ARToolKitController.ts) and then the library API (https://github.com/JamesLMilner/THREEAR/blob/master/src/Controller.ts and create a new marker type). Hope that makes sense!

@JamesLMilner The new jsartoolkit5 has some improvements and differences in rispect of the jsartoolkit version you used for THREEAR. Firstly the WASM support and the NFT feature of course, to add the WASM feature was necessary doing some changes at the beginning and in the last part of the lib where onRuntimeInitialized is called. Apart this fact I think that there are not so great changes in the code, but i don't want to seem too optimistic. I saw that you used a modified version of jsartoolkit and i'am asking to me how did you modify it? Did you used a script for doing this? I have also to admit that i haven't a great knowledge in typescript, this could be a challenge!

russdanner commented 4 years ago

HI there is a ticket #97 that asks about multi-market support which I assume is in relation to NFT. Is there support for multi-market in the recently released NFT support? If not, is there a plan to support it?

I've done some testing and AFAIK only the last marker specified is used.

Thanks for all the great work. I've been tracking the project for years.