Undo command only undoes 9 commands

[JamesLiuZX]

In the user guide, it is stated that undo command cannot undo actions more than 10 iterations old, however, typing undo 10 only undoes 9. Undo command does not count itself as an iteration, since undo 2 undoes the last 2 commands. So I think this is a documentation bug.

--

--

[nus-pe-bot]

Team's Response

Accepted. We include the current state as an iteration in the UG that only 10 states of the DHT are stored. But we think the severity could be lowered as it is rare for users to need to undo exactly 10 times, or will be caught between 9 and 10

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

• [x] I disagree

Reason for disagreement: Considering how this will be used for administrative purposes by NEA for larger datasets, redoing/undoing 10 operations (or whatever the max number of operations is) is common and to be expected as a normal feature instead of a fringe case. Expecting to undo 10 but only undoing 9 can cause data corruption/data loss, and other unintended side effects that compromise the integrity of the database. As per CS2103T guidelines:

Since this is catered for management of larger datasets (more than 100), and this bug occurs everytime 'undo 10' is called, I think it is justified to assign it "occasional" instead of "very rare". And considering the severity of impact of users continuing with operations assuming that it undid the last 10 operations as stated in the documentation guides, causing data loss and other unintended effects, I think it warrants an 'inconvenience' instead of 'minor inconvenience'.

Hence going by the guidelines, this bug should be classified under severity.Medium.

---