search

JamesLongman / Squad-Mortar-Calculator-IOS

IOS App: Mortar calculator for the video game Squad
https://itunes.apple.com/app/id1352781413
MIT License
3 stars 0 forks source link

#29 Implementing automated code review and style guide #30

Closed JamesLongman closed 6 years ago

JamesLongman commented 6 years ago

Testing PR for now to test Codacy's code review

JamesLongman commented 6 years ago

Will ignore travis reviews for now as testing is not yet implemented (will work on soon after completing this issue)

JamesLongman commented 6 years ago

This is coming with a lot of commits as they were necessary for testing but unfortunately for version control that makes this PR a bit of a mess. QA'd in sim extensively as this PR refactors almost every file in the project. Will add tests soon after this to the project so changes like this are less risky. Will check now if Codacy shows any errors on this PR and if not will merge

JamesLongman commented 6 years ago

Looks like the branch has about 100 issues outstanding down from 500, most appear to be from files ignored by the .tailor.yml file (mostly xcode native code such as progressBar.swift) will merge so codacy can also use the yml then hotfix any issues that may be needed referencing the issue and this PR if needed