Open JamesMGreene opened 7 years ago
P.S. Doing this is part of offering full support for React Native: https://github.com/facebook/react-native/issues/526
Related nedb-core commit: https://github.com/nedbhq/nedb-core/commit/1049fc7e5384db693d008b236745436112ea8d2b
May want to consider alternative packages if they suit the needs, e.g.
eslint
and memdown
If sticking with the implementation from binary-search-tree
, then also incorporate the following open PRs from that project:
Perhaps consider addressing existing issue https://github.com/louischatriot/node-binary-search-tree/issues/14 by using inherits
instead of util.inherits
.
Liberate NestDB from the
binary-search-tree
dependency by creating either a separate published module or a local module of the AVLTree.Otherwise, we will forever be stuck with the outdated and unmaintained dependency on
binary-search-tree
, which depends on:util
module, provided by browserify for the browser versioninherits
module from NPM~1.4.4
) userlandunderscore
module that it doesn't even USE!lodash
. Either action would then also allow us to replaceunderscore
withlodash
in the main NestDB repo without incurring the bloat of having bothunderscore
andlodash
present in the prebuilt browser version