JamesMGreene / nestdb

NestDB: An embedded persistent or in-memory database for Node.js, originally forked from NeDB
MIT License
58 stars 7 forks source link

Liberate NestDB from the "binary-search-tree" dependency #28

Open JamesMGreene opened 7 years ago

JamesMGreene commented 7 years ago

Liberate NestDB from the binary-search-tree dependency by creating either a separate published module or a local module of the AVLTree.

Otherwise, we will forever be stuck with the outdated and unmaintained dependency on binary-search-tree, which depends on:

JamesMGreene commented 7 years ago

P.S. Doing this is part of offering full support for React Native: https://github.com/facebook/react-native/issues/526

JamesMGreene commented 7 years ago

Related nedb-core commit: https://github.com/nedbhq/nedb-core/commit/1049fc7e5384db693d008b236745436112ea8d2b

JamesMGreene commented 7 years ago

May want to consider alternative packages if they suit the needs, e.g.

JamesMGreene commented 7 years ago

If sticking with the implementation from binary-search-tree, then also incorporate the following open PRs from that project:

Perhaps consider addressing existing issue https://github.com/louischatriot/node-binary-search-tree/issues/14 by using inherits instead of util.inherits.