Iframe is undefined when QUnit.asyncTest() is invoked

JamesMGreene / qunit-composite

A QUnit plugin for running multiple test files.

Other

34 stars 14 forks source link

Iframe is undefined when QUnit.asyncTest() is invoked #20

Open bobkhoda opened 8 years ago

bobkhoda commented 8 years ago

This issue occurs intermittently and causes the test suite to fail.

A fix was found by checking the iframe and calling initIframe() if the iframe is undefined. A pull request with the changes will be submitted.

JamesMGreene commented 8 years ago

I can't really see how that's possible, unfortunately, and you haven't provided any real info here.

[ ] What are the steps to reproduce this? Can you provide me with a JSFiddle/JSBin/CodePen/repo/etc. that can reproduce this?
[ ] What version of QUnit core are you using?
[ ] What browsers (and versions) does this occur in?

the-t-in-rtf commented 7 years ago

I have the same problem with qunit-composite 1.01-1.2.2, QUnit 1.12.0, and recent versions of Firefox on OS X (52.0.2, for example). The fix @bobkhoda suggested resolves these.

I am attempting to reproduce this in isolation using a branch of the qunit-composite repo and its tests.

the-t-in-rtf commented 7 years ago

I've been trying things with the qunit-composite tests themselves. I can't even get close to QUnit 1.12.0, Firefox 52.0.2 hangs unrecoverably with anything less than 1.15.0. I will use the workaround for now and report here if I can figure a way to reproduce this locally.