search

JamesMGreene / qunit-reporter-junit

A QUnit plugin for producing JUnit-style XML test reports.
Other
42 stars 33 forks source link

Removed attributes no longer valid so that results file can be parsed by xunit #15

Closed rocklan closed 8 years ago

rocklan commented 9 years ago

While trying to parse the results file using xUnit (https://wiki.jenkins-ci.org/display/JENKINS/xUnit+Plugin) I got an error on a few attributes. It seems like these attributes are no longer valid, so removing them from the generated file fixes the problem.

mikelinington commented 9 years ago

@clockwisemusic thanks a lot for this! Saved me a major headache in our jenkins setup.

@JamesMGreene not sure if you're addressing this somewhere else, but I'd +1 merging this if not!

jzaefferer commented 9 years ago

A strict XML parser that bails on extra attributes is kind of broken. That said, the diff looks fine, so hopefully @JamesMGreene gets around to merge this.

JamesMGreene commented 8 years ago

I think there's a bit more to do here for accuracy's sake but I'm going to start by merging this and giving proper credit where credit is due to @clockwisemusic.

JamesMGreene commented 8 years ago

Fixes #1

rocklan commented 8 years ago

cheers @JamesMGreene :)

JamesMGreene commented 8 years ago

Sorry it took, you know, almost a whole 2 years to merge. 😖