JamesMc86 / G-CLI

A proxy mechanism allow LabVIEW programs to easily write out to the command line.
BSD 2-Clause "Simplified" License
71 stars 19 forks source link

g-cli crashes if LabVIEW 2022 Q3 is installed #128

Closed jimkring closed 1 year ago

jimkring commented 1 year ago

Issue

After installing LabVIEW 2022 32-bit, I get the following error when I try to run g-cli

image

I'm suspecting that this problem is due to some changes that NI to LabVIEW 2022, with respect to the version number and how it is stored in the registry.

New LabVIEW Versioning Scheme with YY.Q (e.g. 22.3)

NI started using the minor version of LabVIEW's version for the Quarter of the annual release -- no more "SP1" moving forward.

For example, LabVIEW 2022 Q3 has a version of "22.3" -- and if NI releases a fixes/patches to this (used to be f1, f2, etc.), they will have versions like "22.3.1" and "22.3.2".

Windows Registry is always "YY.0"

Where things get tricky is that the Windows registry keys for the installed LabVIEW versions will always have a zero for the minor version.

For example, LabVIEW 2022 Q3 (version "22.3") has a registry entry here:

Computer\HKEY_LOCAL_MACHINE\SOFTWARE\National Instruments\LabVIEW\22.0

And, for LabVIEW 2023 there will likely be Q1 and Q3 releases having versions "23.1" and "23.3" respectively -- only one of these can be installed at a time, and will show up in the registry at the following location:

Computer\HKEY_LOCAL_MACHINE\SOFTWARE\National Instruments\LabVIEW\23.0

I hope this is helpful. Please let me know if you have any questions or need help testing.

JamesMc86 commented 1 year ago

Hi Jim,

Thanks for the issues and all the detail - that all makes sense and I should be able to tweak the detection for that new scheme.

JamesMc86 commented 1 year ago

The 3.0 version actually handles this correctly (I thought it would still fail!)

So I'll close this off - beta due in the next 48 hours :)

jimkring commented 1 year ago

Great! I'll happily test it out for you.

phorn-NI commented 1 year ago

Hi @JamesMc86 ,

I'm assuming the fix for this should be in the standard package on VI PM now should it?

I'm getting the same error on my VM now image

Version info is

image

And the package is

image

Cheers,

Pete

JamesMc86 commented 1 year ago

Hi Pete,

Yep it should be fixed. The version of the exe you have running is out of date for some reason though even though the package is right, weird!

Easiest fix would be to uninstall the package, also uninstall from add remove programs, then reinstall and hopefully it should get you up to date

James McNally Director/Systems Engineer Wiresmith Technology t: 01635 597171


From: phorn-NI @.> Sent: Thursday, May 18, 2023 4:39:17 PM To: JamesMc86/G-CLI @.> Cc: James McNally @.>; Mention @.> Subject: Re: [JamesMc86/G-CLI] g-cli crashes if LabVIEW 2022 Q3 is installed (Issue #128)

Hi @JamesMc86https://github.com/JamesMc86 ,

I'm assuming the fix for this should be in the standard package on VI PM now should it?

I'm getting the same error on my VM now [image]https://user-images.githubusercontent.com/92914727/239277673-1af680df-b0ec-4f18-894c-283cfa30e880.png

Version info is

[image]https://user-images.githubusercontent.com/92914727/239277794-efc5f84b-b5b4-4526-9dcf-c90fbe403d32.png

And the package is

[image]https://user-images.githubusercontent.com/92914727/239278506-2a02b1f3-afec-4618-b6e5-2bcbdba01914.png

Cheers,

Pete

— Reply to this email directly, view it on GitHubhttps://github.com/JamesMc86/G-CLI/issues/128#issuecomment-1553246831, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABBTHYFDVYOYMIOBVYBRUSLXGY7CLANCNFSM56CHBZ7Q. You are receiving this because you were mentioned.Message ID: @.***>

phorn-NI commented 1 year ago

Ahhh, thanks.

I think I know what happened - I previously had LV 2020 installed on this VM along with g-cli and a bunch of other packages. I uninstalled everything through NI PM before updating, but didn't remove the g-cli exe in add/remove programs, and I guess when I then installed the latest g-cli it didn't update the exe...

Thanks for the help, its working now 👍

425J commented 1 year ago

@JamesMc86 I would suggest adding a recommendation to update g-cli to the latest version due to changes introduced by NI. Admonition on the project main page would be nice.

Also it looks like g-cli exe is not updating automatically which might be considered as a bug.

JamesMc86 commented 1 year ago

Unfortunately as we distribute through VIPM it would need that feature. It actually will prompt you to update packages when you open VIPM but doesn't support it as a background process.