search

JamesMc86 / G-CLI

A proxy mechanism allow LabVIEW programs to easily write out to the command line.
BSD 2-Clause "Simplified" License
71 stars 19 forks source link

G-CLI 3.0.0-beta1 prefers 64 bit version if no --lv-ver #134

Open JamesMc86 opened 1 year ago

JamesMc86 commented 1 year ago

Needs more testing but saw on a local run that despite having 32 bit and 64 bit installed and detected and no -x64 flag set.

Confirm if this is the case - also consider whether we should have a more specific override flag which selects one or the other as 64 bit gets more popular

JamesMc86 commented 1 year ago

The problem is if you don't provide --lv-ver it will just load a default, ignoring the bit flag. Or if you provide one it cant find.

Essentially what do we do in the following cases:

  1. No version provided - get default but should be expanded to match bitness.
  2. Version provided but not found - right now it also gets default but should it?
JamesMc86 commented 1 year ago

Confirmed the old behaviour was at https://github.com/JamesMc86/G-CLI/blob/20706b209ab61fdc0c2619aca3792f18c351a733/C%20Sharp%20Source/LabVIEW%20CLI/Program.cs#L235

Basically if no --lv-ver then just get the "CurrentVersion" which is the last version launched. This also ignores the bit flag so the behaviour is consistent but I still find it a little odd.