JamesOsborn-SE / eat-poop-you-cat-android

party game of telephone with drawings and words
GNU General Public License v3.0
25 stars 1 forks source link

Shrink items on screen for foldable #42

Closed Anti-Apple4life closed 2 months ago

Anti-Apple4life commented 2 months ago

When using the app on the main screen of a Galaxy Z Fold 5, parts of the UI get cut off, making the game more annoying to play. Images are attached below:

Vertical

Screenshot_20240415_182153_Eat Poop You Cat Screenshot_20240415_182312_Eat Poop You Cat

Horizontal

Screenshot_20240415_182201_Eat Poop You Cat Screenshot_20240415_182317_Eat Poop You Cat

JamesOsborn-SE commented 2 months ago

oof... I'll look into this. Thanks for the info

JamesOsborn-SE commented 2 months ago

I found a solution, but it may cause a different issue… I think this is an abuse case though image

JamesOsborn-SE commented 2 months ago

what it should look like on an unfolded phone image

JamesOsborn-SE commented 2 months ago

Thanks again for reporting this bug. This should be fixed in v1.4.4. Reopen if you still have the same/similar issue after you update. Note it may take up to a week for all the app stores to update. If you installed via F-Droid since they publish with my signature you can update you app with the one in the releases here: https://github.com/JamesOsborn-SE/eat-poop-you-cat-android/releases/tag/v1.4.4 and it should not make you uninstall/reinstall

Anti-Apple4life commented 2 months ago

https://github.com/JamesOsborn-SE/eat-poop-you-cat-android/assets/59315931/c8f31582-98c6-47e2-9963-c799380b9e3f

I installed the new update. There is now a different issue that (somewhat) fixes when rotating my phone.

JamesOsborn-SE commented 2 months ago

Good news! I was able to reproduce it in the emulator, so you don't have to lend me your phone.

JamesOsborn-SE commented 2 months ago

Check out the latest release. https://github.com/JamesOsborn-SE/eat-poop-you-cat-android/releases/tag/v1.4.5

I was doing a bad and trying to calculate the size of the component by hand instead of using the right compose widget.