JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.

MIT License

38 stars 5 forks source link

Handle case of zero length notes created in formatters #101

Open JamesOwers opened 5 years ago

JamesOwers commented 5 years ago

TODO: This rounding may result in notes of length 0.

https://github.com/JamesOwers/midi_degradation_toolkit/blob/703885761088d315bec29718dcd8ba46a6834b69/mdtk/formatters.py#L355

apmcleod commented 5 years ago

We had mentioned that this might be fine (even though the note_off precedes the note_on--which is somewhat important). Any model should just learn that such a case corresponds to a very short note.

Otherwise, we can just not include such notes.

JamesOwers commented 4 years ago

We decided to force all notes to be at minimum length 1. This is because the command format is complicated by length zero notes i.e. note off followed by note on in the same time instance.