search

JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.
MIT License
38 stars 5 forks source link

urllib import errors #110

Closed apmcleod closed 4 years ago

apmcleod commented 4 years ago

./make_dataset.py throws an error after following the instructions in the readme.

Specifically, this line needs to change. For some reason, it throws:

AttributeError: module 'urllib' has no attribute 'error'

and

AttributeError: module 'urllib' has no attribute 'request'

So, we have to replace import urllib with:

import urllib.error
import urllib.request

Do you know when/why this has changed? Anyways, I'll make the change in my upcoming amt pull. This is just to notify.

apmcleod commented 4 years ago

I am also somewhat concerned that this may happen elsewhere...

apmcleod commented 4 years ago

I guess this may just be due to some weird update to urllib? But isn't that a built in? And why has it changed? I am using python 3.7.7