search

JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.
MIT License
38 stars 5 forks source link

Interrupting during ./make_dataset download step results in error #116

Closed apmcleod closed 4 years ago

apmcleod commented 4 years ago

If a zip file is incomplete, the following calls return BadZipfile exception. Even calling with --clear-download-cache does this. Only manually deleting the download cache fixes the issue.

apmcleod commented 4 years ago

I think we should add a --clean option that will clear the download cache and input_files directories (with y/n confirmation). The script would clean and then exits. It doesn't require running the full script again.

JamesOwers commented 4 years ago

@apmcleod - please may you outline exactly what to do to reproduce the error?

JamesOwers commented 4 years ago

Add the --clean flag, plus a useful catch for BadZipFile which directs you to use the flag!