search

JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.
MIT License
38 stars 5 forks source link

The overlap check in read_note_csv is dog slow... #24

Closed JamesOwers closed 5 years ago

JamesOwers commented 5 years ago

The line df = df.groupby(['track', 'pitch']).apply(fix_overlapping_notes) increases computation time by at least 100x. This is mad. For now, I'm just going to bypass this by adding a flag to skip the check (we decided not to enforce this), but I think we will learn something if we try to profile the code and understand why it's so slow.

apmcleod commented 5 years ago

Closing as #64 is a more updated version of this issue.