search

JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.
MIT License
38 stars 5 forks source link

Degradation input format #25

Closed apmcleod closed 5 years ago

apmcleod commented 5 years ago

Decide what to use.

The Composition object potentially provides lots of useful functionality for examining the excerpts, but also adds potential overhead and complication if we don't use any of that functionality.

A lower-level solution like directly using a dataframe, array, or dict, might be a better option for some use cases.

apmcleod commented 5 years ago

From a Skype conversation, we have decided that converting inputs/outputs to pandas dataframes is the best way forward.

This will be done in a future PR.

apmcleod commented 5 years ago

Closing this because we seem to be pretty set on DataFrames at the moment, and they work well.