downloads.extract_zip contains assumptions specific to PPD data

JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.

MIT License

38 stars 5 forks source link

downloads.extract_zip contains assumptions specific to PPD data #40

Open apmcleod opened 5 years ago

apmcleod commented 5 years ago

The overwrite check only works if the zipfile contains a top-level directory named the same as the zip file, and the returned path is potentially useless if this isn't the case.

JamesOwers commented 5 years ago

I've done a codebase search for extract_midi to no avail - I don't find it. Can you clarify this issue?

apmcleod commented 5 years ago

Typo... :P I meant here: https://github.com/JamesOwers/midi_degradation_toolkit/blob/f2a2712bad693062f47594b706f5b6742966873f/mdtk/filesystem_utils.py#L69

JamesOwers commented 5 years ago

Gonna kick till later, it's a low priority 'would be nice' kind of issue.