search

JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.
MIT License
38 stars 5 forks source link

Piano midi #41

Closed apmcleod closed 5 years ago

apmcleod commented 5 years ago

Added piano-midi to downloads module.

This works as is, and ignores #40 for now.

JamesOwers commented 5 years ago

To update - I have made a new branch piano-midi-no-ppdd, and merged this into master already, we can merge the final commit of this pr if we decide to later.

apmcleod commented 5 years ago

I agree with your changes, and the current version on make_dataset_script looks good to me. I'll close this one.

I'm also going to go ahead and re-change the url stuff and update the test_downloads file on that branch, so you don't have to worry about those (but you will need to pull).