search

JamesOwers / midi_degradation_toolkit

A toolkit for generating datasets of midi files which have been degraded to be 'un-musical'.
MIT License
38 stars 5 forks source link

Enforce common tempo and pitch basis in downloads. #51

Closed apmcleod closed 5 years ago

apmcleod commented 5 years ago

For example, ensure that C4 = 60 (maybe?) and set up a default tempo for datasets which have a metrical basis.

apmcleod commented 5 years ago

piano-midi: C4 = 60 confirmed piano-midi: tempo is set correctly

apmcleod commented 5 years ago

PPDD also same it seems.

If we want to specify piano, min_pitch=21, max_pitch=108.

apmcleod commented 5 years ago

PPDD confirmed pitch range 21-108.

We will likely want to set this for any degradations / pytorch Datasets we have.

apmcleod commented 5 years ago

Closing this, since #42 is a more appropriate place for the pitch_range discussion. All inputs have the same pitch range and produce ms-based times.