search

JamesRamm / archook

Searches the system for arcgis and makes arcpy available to python (regardless of pythonpath/system path/registry settings)
GNU General Public License v2.0
81 stars 28 forks source link

Added Github actions #32

Closed franTarkenton closed 3 years ago

franTarkenton commented 3 years ago

I added in github actions to automatically build a package when a pr has been merged with master. To make it work you need to populate your repo with the following secrets:

TWINE_PASSWORD TWINE_USERNAME

I moved to using a datetime stamp for the version tag, so minor changes to the

Thanks for your code, saved me a bunch of time... I needed the latest changes in pypy package for another package that I'm working on which is the reason I've forked and built another version in pypi.

mhw-at-yg commented 3 years ago

Thanks! Github action to auto-build will be a welcome addition. I will also add auto-publishing to pypi so no one needs to fork for that reason alone.

mhw-at-yg commented 3 years ago

WRT the action stage which checks if the current commit is a PR, why have "not a pr" be a failure mode? I suppose you're coming from a development model where no work is ever done in the master branch; it's always the recipient of work done elsewhere. To me the practice seems to add a lot of "merge pr xxx" messages in the log which don't convey much info, adding noise. However I'll try the model for a while and see how it works out for me.

I'm not sure downloading arbitrary network content in a CI process is a good practice long term. Is is_pull_request.py something that is intended to go into a PyPi package or similar at some point?