update archook.py - Githubissues

JamesRamm / archook

Searches the system for arcgis and makes arcpy available to python (regardless of pythonpath/system path/registry settings)

GNU General Public License v2.0

81 stars 28 forks source link

update archook.py #9

Closed sandeepgadhwal closed 7 years ago

sandeepgadhwal commented 7 years ago

i propose a change in script if we want to use the script in newer version of python where _winreg is changed to winreg. Thank you for this nice script.

JamesRamm commented 7 years ago

Hi Thanks for this PR and pointing out issues with py3 compatibility. I cant accept the PR as is currently, for 2 reasons:

You have changed the import from _winreg to winreg but none of the references to _winreg - the library wont work!
It is still important to support python 2. A best solution would be to do something like:

try:
  import winreg as _winreg
except ImportError:
   import _winreg