search

JamesRandall / AngularJS-OAuth2

Package for allowing an AngularJS application to authenticate with an OAuth 2 / Open ID Connect identity provider using the implicit flow.
MIT License
46 stars 42 forks source link

Provide tags that match the bower.json #25

Closed ciaranj closed 8 years ago

ciaranj commented 8 years ago

I think that I'm having problems using bower with the library as there are no tags that match the versions you're specifying in the bower.json currently. This is important for me as I need to shrinkwrap/freeze the versions of the libraries which I depend upon. I don't need any historical versions but one matching the current 'released' version would be rather handy for me please :)

JamesRandall commented 8 years ago

Odd. Not sure what's happened there - I'll take a look tomorrow.

JamesRandall commented 8 years ago

Thanks for letting me know!

JamesRandall commented 8 years ago

I've added a tag for the latest version, let me know if it doesn't resolve your issue.

ciaranj commented 8 years ago

Well, it does resolve it, but you have to specify the versions as 'v1.0.5' rather than '1.0.5'. I'm not sure if that was your intention (and I'm even less sure if that's really very semver) ?

JamesRandall commented 8 years ago

I took a look at the bower docs (which says "Your package should use semver Git tags. The v prefix is allowed.") and a number of popular bower packages when doing this (bootstrap, angular itself) - they mostly seem to use a non-prefixed version in the bower.json (so 1.0.5) and a v prefix on the release.

Bower itself seems to understand the v in the release - if I do a bower info angularjs-oauth2 it gives me the output I'd expect (available releases 1.0.5).

Am I misunderstanding something?

ciaranj commented 8 years ago

hmmm, well I guess then all is good on your side. But on my side if I reference in my consuming bower.json "1.0.5" bower doesn't locate your library (or that version at least) if I reference "v1.0.5" it does. HOWEVER I use a private NPM repository (https://github.com/rlidwka/sinopia) so perhaps that isn't respecting things correctly. Let's assume what you've done is right and I'll either just reference with a 'v' in my bower.json or look deeper into sinopia's workings :)

JamesRandall commented 8 years ago

I've got to upgrade a couple of projects myself in the coming days - I'll dig a little deeper myself as I do so.