search

JamesRandall / AngularJS-OAuth2

Package for allowing an AngularJS application to authenticate with an OAuth 2 / Open ID Connect identity provider using the implicit flow.
MIT License
46 stars 42 forks source link

Directive outside of main index.html #27

Open ghost opened 8 years ago

ghost commented 8 years ago

I am currently having an issue with the directive being placed anywhere other then on the main index.html . If i add it to a view being called from a controller the redirect back to the site will not return a token in the session storage and the button will still have a text value of "sign in".

As soon as i add it to the index.html this issue goes away. I am very curious as to why this is occurring and if there is any way in which i can add the <oauth> directive into a view instead of on the main page.

thanks

JamesRandall commented 8 years ago

I'm on holiday at the moment but when I get a chance I'll knock up a sample and see what's going on - I've never used it in that scenario but it should support it.

owjprice commented 8 years ago

I am having the same issue. Is there any update on this?

JamesRandall commented 8 years ago

I'll try and take a look at it at the weekend - I'm super busy at the moment.

JamesRandall commented 8 years ago

I've had a chance to look into this and the problem is caused, at least in my sample app, by the .otherwise entry in the Angular router redirecting to the root and losing the full URL before the directive embedded on the page can get to it.

One possibility is to update the .otherwise to also include the parameters but I'm looking to see if there is a more seamless solution.