search

JamesRandall / AngularJS-OAuth2

Package for allowing an AngularJS application to authenticate with an OAuth 2 / Open ID Connect identity provider using the implicit flow.
MIT License
46 stars 42 forks source link

Handle secure login on the '/' path #30

Closed ciaranj closed 8 years ago

ciaranj commented 8 years ago

It seems that for the case where the route is '/' the redirect that clears the uri hashes does not fire,

I believe this is because the 'oauthRedirectRoute' value stored in sessionStorage is an empty string in this case which resolves to a truthy false.

JamesRandall commented 8 years ago

Thanks again for the pull request. Let me give it a quick test and I'll merge the request.

ciaranj commented 8 years ago

any joy ?

JamesRandall commented 8 years ago

Thanks for the contrib again - sorry it took me a while to test. Will be bumping bower version shortly.

ciaranj commented 8 years ago

Cheers! On Thu, 25 Feb 2016 at 12:35, James Randall notifications@github.com wrote:

Thanks for the contrib again - sorry it took me a while to test. Will be bumping bower version shortly.

— Reply to this email directly or view it on GitHub https://github.com/JamesRandall/AngularJS-OAuth2/pull/30#issuecomment-188766054 .