search

JamesRandall / FunctionMonkey

Write more elegant Azure Functions with less boilerplate, more consistency, and support for REST APIs. Docs can be found at https://functionmonkey.azurefromthetrenches.com
MIT License
294 stars 50 forks source link

SignalR Negotiate: access token lifetime #123

Open alexeymarkov opened 4 years ago

alexeymarkov commented 4 years ago

Hi James,

I found in the MS implementation that the default access token lifetime is 1 hour: ServiceOptions.cs Constants.cs

// Default access token lifetime public static readonly TimeSpan DefaultAccessTokenLifetime = TimeSpan.FromHours(1);

Could you please change it also from 30 minutes to 1 hour in your implementation?

Or better make it configurable or utilize SignalR ServiceOptions. Sure, if MS opened their AzureSignalRClient it would be perfect (maybe it is worth contacting the Azure team...).

Regards, Alexey

alexeymarkov commented 4 years ago

I just found out this is already possible to generate an instance of SignalRConnectionInfo using existing SignalR extension implementation. Have a look at the sample.

JamesRandall commented 4 years ago

Cool, I’ll get that included! Thanks!

Get Outlook for iOShttps://aka.ms/o0ukef

From: alexeymarkov notifications@github.com Sent: Monday, February 3, 2020 10:29:05 AM To: JamesRandall/FunctionMonkey FunctionMonkey@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [JamesRandall/FunctionMonkey] SignalR Negotiate: access token lifetime (#123)

I just found out this is already possible to generate an instance of SignalRConnectionInfo using existing SignalR extension implementation. Have a look at the samplehttps://github.com/Azure/azure-functions-signalrservice-extension/blob/dev/samples/simple-chat/csharp/FunctionApp/Functions.cs#L33l.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/JamesRandall/FunctionMonkey/issues/123?email_source=notifications&email_token=AABZVV72WHHYRJQ75BEJ6DTRA7WXDA5CNFSM4KPCSQZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKTJSAY#issuecomment-581343491, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AABZVV4EQDSRZMTJUZPJEHLRA7WXDANCNFSM4KPCSQZQ.