JamesRitchie / language-matlab

MATLAB/Octave language support for Atom
15 stars 9 forks source link

Adding to "standard" snippet completion an improved, Sublime-Text-converted one #27

Open ehteqx opened 7 years ago

ehteqx commented 7 years ago

Hello, I know that you are looking for a new package maintainer and the package is no longer actively developed. However I recently (happily) migrated from Sublime Text to Atom and I found a lack of proper support for more specific MATLAB functions apart from the base ones.

Yesterday I really needed it, and I hacked together a quick-and-dirty solution by converting the Sublime Text package which is used also in VSCode in an Atom-compatible version.

I used a modified version of this NodeJS-powered converter, whose remains are still present as a leading comment in files (that I hadn't the time to remove/adapt), that I had to tweak and make it work together with a Perl script in order to strip the trailing comma from Sublime-style JSON converting it into proper JSON.

It's not a finely-crafted solution, but - for now - it seems to work perfectly.

I also updated the contributors list to acknowledge the maintainer of Sublime's snippets.

P.S.: I have no proper experience in "packaging" of Atom packages or JS development, so I preferred to pull the request to the most-downloaded MATLAB package for Atom. It would be great to have it pulled to the official Atom repository.

Thank you in advance!

EDIT: I have updated the Pull Request after I realized I had already removed from the original Sublime completions those duplicated in the already-existing codebase converted from TextMate. Now it should autocomplete both the built-in functions (with the completions already present in the repository) and the added ones. Sorry for the noise.