Closed JamesRobertSutcliffe closed 1 year ago
vercel[bot]
commented
1 year ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| personality-music-recommender-jer1 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 11, 2023 10:56pm |
JamesRobertSutcliffe
commented
1 year ago I cannot seems to fix the vercel deployment issues. I am hoping you can pull locally and test.
patdel0
commented
1 year ago You're doing an amazing job!
This is a huge chunk of work.
You're right, the email could be used as a unique identifier and is something we need! The top played tracks info is great as well, nice find!
patdel0
commented
1 year ago I have fixed the deployment, and addressed some errors that were showing up for me. These changes should not be permanent, as data validation is something we should apply in a more thought out way. Essentially, we are getting empty responses and are not handling those appropriately. But it seems like you're aware of this already and intend to work on that in future changes
Although the errors are fixed, the scenarios that were causing the errors, were not.
Spotify API GET requests are now functioning. See individidual commits for specifics. Personalise Homepage updated is where the main action is. In regards to this page:
1 - You will notice I have pulled the access token from the window URL, this is probably not very good practice, I can look at amending this further down the line. 2 - The data rendered to cards is just placeholder stuff from random parts of the spotify API including specifically targeted artists albums and stuff relating to users profiles (emails, profil image, Username, top tracks). I just wanted to get this set up so we can amend what we pull once we develop app further. 3 - There is a commented section stating useful data for ML / backend, below this variables store logged in users top tracks via an array of IDs (I am hoping this is what you need) and users email (I was thinking this could be a unique identifier for our users. If any other data is needed for next steps we can go in and pull.
I am sure I could improve the promises to catch errors and improve the aestectics (a bit clunky looking), I will certainly do this in the future and polish everything. But please guide me to any major errors that will be very problematic for developing the project further if neccessary!