search

JamesRobertSutcliffe / personality-music-recommender

A music recommender web app that bases reccomendations on personality type. Developed with next.js, Typescript, PostgreSQL and docker.
https://personality-music-recommender-jer1.vercel.app/
0 stars 0 forks source link

Chore/create image placeholder #58

Closed JamesRobertSutcliffe closed 1 year ago

JamesRobertSutcliffe commented 1 year ago

Also some general cleanup with re-optimisation for typescript.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
personality-music-recommender-jer1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2023 7:49pm
JamesRobertSutcliffe commented 1 year ago

Thanks for this, I will make the change to this and try and write some tests!

JamesRobertSutcliffe commented 1 year ago

I have added some commits. Here is what I have done / tried to achieve -

1- I have created a placeholder "Loading" component that appears until profile data is fetched. This stops the image from flipping. I intend to change the loading text to a slicker loading animation in the future 2 - I have changed the dependency on displaying the placeholder logo to on the data fetched being undefined - hopefully this fixes. 3 - I have created tests in the 'profilePic.spec.ts' file - I was a little unsure what I was doing here or if I did it correctly so not sure how useful they are 4 - Please also test using your profile - hopefully the previous issues of logo displaying innappropriately / flicking between logo / profile pic is not fixed

I have also noticed that there is not a deployment issue. I do not have time to fix now. Let me know if you would prefer I fix this before checking, if not I can try and fix after you text / review.