Open JamesSaxon opened 5 years ago
Created a new branch (FCAand2SFCA) with the first round implementation of the base FCA and Two Stage FCA methods.
Thanks Bryan, these look good. A couple of things --
fca1.py
, I would prefer that the defaults for demand_index
and supply_index
remain True
instead of geoid
, since the latter is less general. As it is, the access class will try to do this -- that is, set the location names to the index.df.to_frame(name = ).join(df2.to_frame....
calls are a little verbose. I might suggest pd.concat
-- something like
s2 = pd.Series(index = range(10), data = range(0, 20, 2))
s3 = pd.Series(index = range(10), data = range(0, 30, 3))
df = pd.concat([s2, s3], axis = 1)
although you could convince me that dealing with missing values in this case is enough messier to justify your way.
Follow the format laid out in access/access/fca/
weighted_catchment
method if possible.[x] Ultimately this should be tested (i.e., matching the earlier functions), as:
This is the main priority for the week of June 24.