JamesSweetJones / abYdraw

Input expressions of antibodies in AbML format and output drawings of their shape
GNU General Public License v3.0
3 stars 1 forks source link

Ensure VHH is always rendered correctly #18

Closed AndrewCRMartin closed 2 years ago

AndrewCRMartin commented 2 years ago

The following renders correctly except that the VHH displays as a VH instead of a VHH:

VHH.a(1:5){1}-H(2:6){2}-CH2(3:7)-CH3(4:8)|VHH.a(5:1){1}-H(6:2){2}-CH2(7:3)-CH3(8:4)
AndrewCRMartin commented 2 years ago

I separated out the second issue

JamesSweetJones commented 2 years ago

I see the issue. This is because I initially did not allow VHH domains to be paired with another to demonstrate that they are single domain Fv fragments. I can have this changed so it allows a disulphide between two VHH domains.

AndrewCRMartin commented 2 years ago

That's great - but the VHH still now renders as a VH instead of a VHH :)

JamesSweetJones commented 2 years ago

Sorted

AndrewCRMartin commented 2 years ago

It still renders as a VH instead of a VHH for me!

VHH.a(1:5){1}-H(2:6){2}-CH2(3:7)-CH3(4:8)|VHH.a(5:1){1}-H(6:2){2}-CH2(7:3)-CH3(8:4)

Screenshot from 2022-02-17 16-40-40

Compared with

VHH.a(1)-H(2:6){3}-CH2(3:7)-CH3(4:8)|VHH.a(5)-H(6:2){3}-CH2(7:3)-CH3(8:4)

Screenshot from 2022-02-17 16-42-48

JamesSweetJones commented 2 years ago
Screenshot 2022-02-17 at 16 49 40

This is what I'm getting now. If you use the latest version of the programme, this issue is gone when using the expression I've used here. I've also replaced the Camelid antibody in the library for this structure

AndrewCRMartin commented 2 years ago

Ah - brilliant - I must have done my git pull too soon!!!!

JamesSweetJones commented 2 years ago

Yes, that's probably me responding to your query and then updating the code. I'll do it from the other way around now.