JamesSweetJones / abYdraw

Input expressions of antibodies in AbML format and output drawings of their shape
GNU General Public License v3.0
3 stars 1 forks source link

NOTE: doesn't seem to work #24

Closed AndrewCRMartin closed 2 years ago

AndrewCRMartin commented 2 years ago

I created the following structure:

VL.a(1:3)-L(2)-VH.a(3:1)-L(4)-X(5:6)|X(6:5)

I then wanted to add a note to say what X was. It displayed as I added it, but then Tidy failed with

Exception in Tkinter callback
Traceback (most recent call last):
  File "/usr/lib64/python3.7/tkinter/__init__.py", line 1705, in __call__
    return self.func(*args)
  File "./abYdraw.py", line 7691, in <lambda>
    button = tk.Button(frame, text = "Tidy", bg = "#CFCFCF", font=20, command=lambda: sequence_render_pipeline(lower_canvas))
  File "./abYdraw.py", line 3810, in sequence_render_pipeline
    exp = sequence_pipeline(lower_canvas)
  File "./abYdraw.py", line 4862, in sequence_pipeline
    note2 = non_redundant_comments[x].split(":")[1]
IndexError: list index out of range

I also tried doing a TYPE: OTHER first, then adding the NOTE: but it still didn't work. I also tried adding a NOTE: to a different domain with no success.

Adding a NOTE: to the AbML manually worked and rendered fine:

VL.a(1:3)-L(2)-VH.a(3:1)-L(4)-X(5:6)[NOTE: Fused X is TCRb, paired with TCRa]|X(6:5)

TYPE: and NOTE: should both be addable to any domain - either alone or together

JamesSweetJones commented 2 years ago

Thanks for letting me know, Andrew. This is a pretty weird effect actually as it seems to be fine for shorter comments so probably something about the length of the comments is causing it to be ignored. I shall look into this.

JamesSweetJones commented 2 years ago

I've found the issue and it's because there is a comma in your comment. As the comments are comma-separated it thinks there are two comments there so it's expecting an additional "NOTE:" specification but can't find one. Perhaps use a semi-colon instead?

AndrewCRMartin commented 2 years ago

Ah! That makes sense. I can't use ';' in WHO annotations since that indicates the end of a record.

Can I suggest removing commas from the text that is typed in if it messes things up?

A.

On Wed, 23 Feb 2022 at 14:29, James Sweet-Jones @.***> wrote:

I've found the issue and it's because there is a comma in your comment. As the comments are comma-separated it thinks there are two comments there so it's expecting an additional "NOTE:" specification but can't find one. Perhaps use a semi-colon instead?

— Reply to this email directly, view it on GitHub https://github.com/JamesSweetJones/abYdraw/issues/24#issuecomment-1048838799, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBQ7ULDTIDYANIGQRVMOJDU4TVMPANCNFSM5PEL4FFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Andrew C.R. Martin Professor of Bioinformatics and Computational Biology. Institute of Structural and Molecular Biology, UCL http://www.bioinf.org.uk/ Twitter: @PrfAndrewMartin

JamesSweetJones commented 2 years ago

No worries. This has now been sorted.