JamesSweetJones / abYdraw

Input expressions of antibodies in AbML format and output drawings of their shape
GNU General Public License v3.0
3 stars 1 forks source link

AbML won't render with a connector but will with a linker #25

Closed AndrewCRMartin closed 2 years ago

AndrewCRMartin commented 2 years ago

The following won't render - I drew it and it generated the AbML, but it won't render... This is a Fab with an appended scFv on the light chain with a normal connection between CL and VH.b

VH.a(1:3)-CH1(2:4)|VL.a(3:1)-CL(4:2)-VH.b(5:7)-L(6)-VL.b(7:5)

If I change the normal connection to a linker then it renders fine:

VH.a(1:3)-CH1(2:4)|VL.a(3:1)-CL(4:2)-L(5)-VH.b(6:8)-L(7)-VL.b(8:6)

I think it's fine if we don't allow a normal connection, but we need to have a proper error message rather than a Python error :)

JamesSweetJones commented 2 years ago

I've just made a change so whenever there's an issue rendering a domain, a generic error message will pop up. I can work on it so it says something a bit more specific.

AndrewCRMartin commented 2 years ago

Also needs an error message to deal with missing domain numbers. e.g.

VH.a(1:3)-CH1(2:4)|VL.a(3:1)-CL(4:2)-L-VH.b(5:7)-L(6)-VL.b(7:5)

where I added a linker but didn't include a number for it.

JamesSweetJones commented 2 years ago

This has been fixed