search

JamesSweetJones / abYdraw

Input expressions of antibodies in AbML format and output drawings of their shape
GNU General Public License v3.0
3 stars 1 forks source link

Structure with a linker leading to the hinge won't render #42

Open AndrewCRMartin opened 1 year ago

AndrewCRMartin commented 1 year ago

I have a structure with two VHHs on each arm and a linker between the 2nd VHH and the hinge. It won't render (and I can't draw it, but that's less of a problem)

VHH.a(1)-L(2)-VHH.a(3)-L(5)-H(5:12){2}-CH2(6:13)-CH3(7:14)|VHH.a(8)-L(9)-VHH.a(10)-L(11)-H(12:5){2}-CH2(13:6)-CH3(14:7)
JamesSweetJones commented 1 year ago
Screenshot 2022-09-09 at 10 50 09

I think I may have got this working! In the newest push

JamesSweetJones commented 1 year ago

I think the issue was that you have two domains numbered 5. I'll modify the code so it warns you of this in the future!

AndrewCRMartin commented 1 year ago

Ah - OK - that was my manual rewriting. From one I had drawn without the linker before the hinge. Can you draw this in abYdraw?

On Fri, 9 Sept 2022 at 10:53, James Sweet-Jones @.***> wrote:

I think the issue was that you have two domains numbered 5. I'll modify the code so it warns you of this in the future!

— Reply to this email directly, view it on GitHub https://github.com/JamesSweetJones/abYdraw/issues/42#issuecomment-1241758774, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBQ7UPXWAANJ7W5OKXQX4TV5MCJTANCNFSM6AAAAAAQH6M6OQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Andrew C.R. Martin Professor of Bioinformatics and Computational Biology. Institute of Structural and Molecular Biology, UCL http://www.bioinf.org.uk/ Twitter: @PrfAndrewMartin

AndrewCRMartin commented 1 year ago

Can you ensure you remember to tag each new version number in Git:

git tag V1.04 git push --tags

That then builds a release that you can download as a .zip or .tgz file as well as being easier to find specific versions!

I suggest having a little script called 'release' that takes a version number, patches that into the abydraw.py code, builds the Mac and Windows versions, does the git tag, pushes all code and pushes the tags and you just run that each time you have a new version to release.

A.

On Fri, 9 Sept 2022 at 12:42, Andrew Martin @.***> wrote:

Ah - OK - that was my manual rewriting. From one I had drawn without the linker before the hinge. Can you draw this in abYdraw?

On Fri, 9 Sept 2022 at 10:53, James Sweet-Jones @.***> wrote:

I think the issue was that you have two domains numbered 5. I'll modify the code so it warns you of this in the future!

— Reply to this email directly, view it on GitHub https://github.com/JamesSweetJones/abYdraw/issues/42#issuecomment-1241758774, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBQ7UPXWAANJ7W5OKXQX4TV5MCJTANCNFSM6AAAAAAQH6M6OQ . You are receiving this because you authored the thread.Message ID: @.***>

-- Andrew C.R. Martin Professor of Bioinformatics and Computational Biology. Institute of Structural and Molecular Biology, UCL http://www.bioinf.org.uk/ Twitter: @PrfAndrewMartin

-- Andrew C.R. Martin Professor of Bioinformatics and Computational Biology. Institute of Structural and Molecular Biology, UCL http://www.bioinf.org.uk/ Twitter: @PrfAndrewMartin