search

JamesTeague / ubiquitous-train

Apache License 2.0
0 stars 0 forks source link

The user should be able to log out #11

Closed JamesTeague closed 6 years ago

JamesTeague commented 6 years ago

Once logged in the user should have a way of logging out.

gpwilson commented 6 years ago

@JamesTeague Seems to be issue with signing out once signed in with Google. It will appear signed out (can see sign in screen) for a moment then it looks like Google signs the user back in. Is that a known issue and/or something you want to address?

gpwilson commented 6 years ago

Note: For testing purposes, can get around the issue by removing permissions on Google here and signing out from Retreat.

JamesTeague commented 6 years ago

@gpwilson, it is a known issue but I have no idea how to prevent that from happening. If you have any thoughts or resources, please let me know. My original thought was to remove the Google sign in all together and force email and password. Thoughts on that?

gpwilson commented 6 years ago

@JamesTeague I think removing Google sign in would be fine if not able to find solution to the Google sign out issue. Could be added back as an enhancement further down the line if desired?

gpwilson commented 6 years ago

Am able to sign out when signed in with email/password.

@JamesTeague Should this ticket be closed and a new ticket created to track Google sign out?

JamesTeague commented 6 years ago

Leave it open for now until there is a resolution.

JamesTeague commented 6 years ago

I think there should be some information to be gained from this link on stackoverflow. We should try this out here and see what results we can get. This would probably require some extensive testing before deploying.

gpwilson commented 6 years ago

Signed in with Google and was able to successfully sign out. Reloaded the page. Was not automatically signed in with Google (as expected). Was able to sign in with email/password. Signed out. Was able to sign in with Google. Signed out. Status: Pass