JamesVeug / AgainstTheStormAPI

Mod that adds helper methods for other mods and fixes/QOL changes for the game
GNU Lesser General Public License v2.1
1 stars 1 forks source link

[Request New Feature] Set `HookedEffectBuilder` Retroactive & Preview text key #2

Open Forwindzz opened 2 weeks ago

Forwindzz commented 2 weeks ago

Hi, I want to add 2 api functions in class HookedEffectBuilder. The api currently has HookedEffectBuilder.SetPreviewDescription, but does not have SetPreviewDescriptionKey. It might be a bit wired, compare to the api design of SetDescriptionKey and SetDescription So, I would like to request two new api SetPreviewDescriptionKey and SetRetroactiveDescriptionKey in HookedEffectBuilder.

HookedEffectBuilder builder = new(PluginInfo.PLUGIN_GUID, cornerstoneName, cornerstoneIconPath);
builder.SetDescriptionKey($"description_key"); //invoke EffectBuilder<T>.SetDescriptionKey() method
builder.SetDisplayNameKey($"displayName_key");//invoke EffectBuilder<T>.SetDisplayNameKey() method
// API does not have these two methods :(
builder.SetPreviewDescriptionKey($"preview_key"); 
builder.SetRetroactiveDescriptionKey($"retroactive_key");
JamesVeug commented 2 weeks ago

Ah they were definitely missed! Added and ready for v2.3.0