JamesWilko / Payday-2-BLT-Lua

Mods folder that controls the ingame aspects of the Payday 2 BLT.
MIT License
16 stars 26 forks source link

LuaNetworking has missing validty checks #29

Closed neico closed 7 years ago

neico commented 7 years ago

Some functions like LuaNetworking:GetPeers() or LuaNetworking:GetNumberOfPeers() (which actually could use the former in it's loop) reference managers.network:session() directly, without making sure if it's still valid, the Chat Manager mod for example causes a DelayedCall error if you get kicked by one of those lobby requirement mods: LuaNetworking error

One could probably argue that it's careless to call a LuaNetworking function without checking if you have valid network session, but imo this class is trying to hide some underlying challenges, and shouldn't cause any errors on it's own trying to do so.