JamesWoolfenden / sato

Sato converts ARM or CFN into Terraform
Apache License 2.0
104 stars 6 forks source link

AWS::Athena::WorkGroup and AWS::Athena::NamedQuery -> Not found #15

Closed oijkn closed 3 months ago

oijkn commented 4 months ago

Describe the bug When I run the command sato parse -f athena.yaml, the following warnings appear in the log:

10:07AM WRN AWS::Athena::WorkGroup not found
10:07AM WRN AWS::Athena::NamedQuery not found

As a result, the Terraform configuration generation fails.

To Reproduce Steps to reproduce the behavior:

  1. Create a file named athena.yaml with the following configuration:

    Resources:
    
    athenworkgroup:
    Type: AWS::Athena::WorkGroup
    Properties:
      Name: "my-workgroup"
      State: "ENABLED"
    
    securityhubAthenaView:
    Type: AWS::Athena::NamedQuery
    Properties:
      Name: AWS-athena
      Database: !Ref database
      WorkGroup: !Ref athenworkgroup
      QueryString: >
          SELECT * FROM "my_table" WHERE "severity" = 'CRITICAL'
  2. Execute the command: sato parse -f athena.yaml.
  3. Observe the warnings in the log.

Expected behavior The configuration should be parsed without warnings, and the Terraform configuration should be generated successfully.

Screenshots N/A

Additional context Any guidance or fixes for this issue would be greatly appreciated. Thank you!

JamesWoolfenden commented 3 months ago

thanks for logging this ill take a look

JamesWoolfenden commented 3 months ago

I have added new support for these resources athena namedquery and workgroup

JamesWoolfenden commented 3 months ago

resolved in 0.1.17