Use setpriv instead of gosu / fix Podman SIGTERM failed

Jamesits / docker-ripe-atlas

This is the RIPE Atlas software probe packaged as a Docker image.

https://hub.docker.com/r/jamesits/ripe-atlas

GNU General Public License v3.0

151 stars 22 forks source link

Use setpriv instead of gosu / fix Podman SIGTERM failed #29

Closed Dreista closed 9 months ago

Dreista commented 9 months ago

setpriv is already included in Debian 10+'s util-linux, I guess we no longer need gosu anymore.

Dreista commented 9 months ago

My bad, just noticed that this would make docker stop ripe-atlas stuck for a long time. However, even without this change it is already broken for Podman users. Probably we'd better add --init to README.md?

WARN[0010] StopSignal SIGTERM failed to stop container ripe-atlas in 10 seconds, resorting to SIGKILL

Edit: Podman --init's behvior seems to be different from Docker's and passing --init does not seem to fix this for Podman users. Fixed by introducing tini.