search

Jamesits / docker-ripe-atlas

This is the RIPE Atlas software probe packaged as a Docker image.
https://hub.docker.com/r/jamesits/ripe-atlas
GNU General Public License v3.0
155 stars 21 forks source link

atlas - source not found #34

Open sebastianschauenburg opened 2 months ago

sebastianschauenburg commented 2 months ago

When starting the container, the probe does not turn up (REGINIT exit with error). Currently running on Debian 12 (Bookworm). Looking into the container logs, I notice some other errors, which I wanted to report:

/usr/local/bin/atlas: 23: source: not found
/usr/local/bin/atlas: 24: source: not found
/usr/local/bin/atlas: 25: source: not found
/usr/local/bin/atlas: 26: source: not found
/usr/local/bin/atlas: 27: source: not found

This refers to these lines from /usr/local/atlas/bin/ATLAS:

source $ATLAS_STATIC/bin/support.lib.sh
source $ATLAS_STATIC/bin/class.lib.sh
source $ATLAS_STATIC/bin/array.lib.sh
source $ATLAS_STATIC/bin/json.lib.sh
source $ATLAS_STATIC/bin/atlas_log.lib.sh

So by default the container uses dash, which does not have source. With dpkg-reconfigure dash it can be changed back to bash (by default) or the shell scripts need to be updated. For compatibility, I'd suggest to change the default shell for this container.

Looking further into the Dockerfile and then at the Debian package, the sourced scripts do not appear to be available, since this returns nothing: dpkg -L atlasswprobe|grep 'lib.sh'.

Does anyone else also experience this issue?

Jamesits commented 2 months ago

See https://github.com/RIPE-NCC/ripe-atlas-software-probe/pull/88 which should be fixed in the next version.

sebastianschauenburg commented 2 months ago

@Jamesits excellent upstream bugreport (thanks for the pointer)

Tried to build the .deb manually, which worked and included the scripts, but I used upstream master and Debian 12 to build it. But after that :man_facepalming: I noticed you used a specific commit. So I just tried to build it from scratch with that commit (to check the contents of the generated .deb), no dice so far (libevent build error, but that's on me and the way I'm trying to build it).

Jamesits commented 2 months ago

We had some issues upgrading to upstream version 5090, so we are currently pinned to 5080 manually. (See https://github.com/Jamesits/docker-ripe-atlas/issues/31 )

Support for 5090 is still in progress, CC @Dreista