Jamie-Landeg-Jones / byte-unixbench

Automatically exported from code.google.com/p/byte-unixbench
0 stars 0 forks source link

Project makefile is not parallel make safe. #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run make -j 4 (anything > 3 will cause failure)
2. Observe errors about dhry_1.o or dhry_2.o files.

What is the expected output? What do you see instead?

Project should compile without error using parallel make. Instead, project 
fails to compile due to race conditions in the construction and deletion of  
the dhry_1.o and dhry_2.o files.

What version of the product are you using? On what operating system?

All versions as far back as 4.0.1 (at least, probably always). Linux.

Please provide any additional information below.

Attached is a patch file to change the dhry2reg target to compile its versions 
of the dhry_1.o and dhry_2.o files to dhry_1_reg.o and dhry_2_reg.o so that the 
dhry2 target doesn't overwrite them.

Original issue reported on code.google.com by dalecur...@google.com on 13 Jan 2011 at 8:11

Attachments:

GoogleCodeExporter commented 9 years ago
I'll take a look and see if these changes cause any issues. If all looks well 
I'll integrate the change into UnixBench.

Original comment by kdlu...@gmail.com on 13 Jan 2011 at 9:11

GoogleCodeExporter commented 9 years ago
I added the patch, recompiled on Ubuntu Lucid 2.6.32x kernel, and ran Unixbench 
with -c 16 and all ran well. Let me check with Ian and if he's ok I'll bump the 
version to 5.1.3 and push it.

Original comment by kdlu...@gmail.com on 13 Jan 2011 at 10:55

GoogleCodeExporter commented 9 years ago
Ok, I integrated the patch and rev'd UnixBench to 5.1.3. Please test it and let 
me know if that works for you.

Original comment by kdlu...@gmail.com on 14 Jan 2011 at 6:07