search

JamieKitson / GeoTagger

Google Location History Flickr GeoTagger
http://geo.kitten-x.com
4 stars 1 forks source link

Avoid spurious "upload 100%" with removeEventListener #20

Closed JamieKitson closed 12 years ago

JamieKitson commented 12 years ago

Sometimes you see "Uploading data:" and a 100% full progress bar. I believe is fired when go.php starts passing data back to index.php in Firefox. We could use removeEventListener to stop this happening.

JamieKitson commented 12 years ago

The seems to happen particularly after the first photo has been written to.

JamieKitson commented 12 years ago

This suggests that the data is being flushed, maybe I should work on that to get the upload progress bar working correctly instead of fixing my fix with removeEventListener.

JamieKitson commented 12 years ago

Simpler fix: don't set upload.addEventListener('load since that function gets called when progress > 75% anyway.

JamieKitson commented 12 years ago

In fact don't even need to not set the load EventListener, but rather check if we've already got past that point with 8f4b02b

JamieKitson commented 12 years ago

...and c25670a.