search

JamieMason / ImageOptim-CLI

Make optimisation of images part of your automated build process
https://foldleft.io/image-tools
MIT License
3.45k stars 126 forks source link

fix(osx): add support for high sierra #153

Closed paleite closed 6 years ago

paleite commented 6 years ago

High Sierra uses one "sheet" less than Sierra. Fixes https://github.com/JamieMason/ImageOptim-CLI/issues/152

JamieMason commented 6 years ago

Fantastic, thanks @paleite I will merge this when I next come to work on this project 🎉

paleite commented 6 years ago

Glad I could contribute, @JamieMason 😄

JamieMason commented 6 years ago

Note: Need to change commit message to fix(osx): add support for high sierra to follow commitizen convention 👍 . I can do this no problem when I come to merge it.

JamieMason commented 6 years ago

Thanks a lot, this was merged and released in 1.15.3

paleite commented 6 years ago

@JamieMason Hey, looks like the commit wasn't merged. Could you check, please?

JamieMason commented 6 years ago

I've messed up here:

Showing 0 changed files with 0 additions and 0 deletions. – https://github.com/JamieMason/ImageOptim-CLI/commit/6208dc44721cd82c71f3e16e9795b3ca503c481e

JamieMason commented 6 years ago

@paleite would it be straightforward to edit your commit message to fix(osx): add support for high sierra? I use commitizen-changelog so the format is important. Then I can rebase this in directly. Thanks

paleite commented 6 years ago

@JamieMason I didn't know how to do that, but I created a new PR instead with the correct commitizen-message: https://github.com/JamieMason/ImageOptim-CLI/pull/157

I guess you can just close this again :)

JamieMason commented 6 years ago

Thanks a lot 😆 sorry for the extra hassle!

paleite commented 6 years ago

@JamieMason don't worry about it. Glad I could help :)