search

JamieMason / ImageOptim-CLI

Make optimisation of images part of your automated build process
https://foldleft.io/image-tools
MIT License
3.46k stars 126 forks source link

Update `nexe` to 2.0.0-rc.30. #166

Closed reitermarkus closed 6 years ago

reitermarkus commented 6 years ago

Types of Changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

Fixes build when stdin is not a TTY.

Related Issues

https://github.com/nexe/nexe/pull/496 https://github.com/Homebrew/homebrew-core/pull/28873.

Justification

– " –

How Can This Be Tested?

Build with printf '' | npm run build and then try using ./dist/imageoptim -V. The output will be empty before this fix.

ilovezfs commented 6 years ago

doesn't the package-lock.json file need updating too?

reitermarkus commented 6 years ago

doesn't the package-lock.json file need updating too?

Right. I updated the file via GitHub.

ilovezfs commented 6 years ago

🎉

JamieMason commented 6 years ago

I don't mind doing that when I merge it, thanks a lot.

JamieMason commented 6 years ago

@reitermarkus out of interest, does this update contain anything in particular that you need?

EDIT: Just seen the related issue, I see now 👍

ilovezfs commented 6 years ago

@JamieMason see https://github.com/Homebrew/homebrew-core/pull/28873. The upgrade was needed in order to get a non-broken build on our Jenkins CI. Otherwise, despite a seemingly successful build the program would just output nothing.

ilovezfs commented 6 years ago

@JamieMason on a related note, you may want to add brew install imageoptim-cli as a suggested way of installing! :)

JamieMason commented 6 years ago

see #18 @ilovezfs, we tried that a while back but no dice. This PR should be merged soon.

ilovezfs commented 6 years ago

@JamieMason but now you have dice! I have merged imageoptim-cli into Homebrew/homebrew-core already. See https://github.com/Homebrew/homebrew-core/commit/ad3ec7905f3bfb9c64cc5eb16a5753cef78d15cd https://github.com/Homebrew/homebrew-core/commit/abca9752a87c50cf5e815e44eefac80dbe2db573

JamieMason commented 6 years ago

ha, no way! 😆 thanks @ilovezfs I'll go check that out after I've done this release.

/cc @jamesstout

ilovezfs commented 6 years ago

@JamieMason you're welcome. It was really @reitermarkus's doing!

JamieMason commented 6 years ago

👏 @reitermarkus 👏 @ilovezfs 👏

Love it, nice one!

JamieMason commented 6 years ago

Just published imageoptim-cli@2.0.3 by the way, thanks a lot

ilovezfs commented 6 years ago

Voilà https://github.com/Homebrew/homebrew-core/pull/28978

JamieMason commented 6 years ago

👌

jamesstout commented 6 years ago

Excellent. thank you.

On 13 Jun 2018, at 6:02 PM, Jamie Mason notifications@github.com wrote:

👌

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JamieMason/ImageOptim-CLI/pull/166#issuecomment-396884369, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgM_paKE_sqhRtsRxYCfr6pOkQkeZsoks5t8OM7gaJpZM4UlhD4.