search

JamieMason / shrinkpack

Fast, resilient, reproducible builds with npm install.
https://www.npmjs.com/package/shrinkpack
MIT License
793 stars 38 forks source link

"@latest" in npm-shrinkwrap.json skips shrinkpack #54

Closed JamieMason closed 8 years ago

JamieMason commented 8 years ago

Expected behaviour

npm install --loglevel http should report no network activity when installing a shrinkpacked project.

Actual behaviour

Network activity is reported in some circumstances (see below).

npm http request GET http://registry.npmjs.org/options
npm http 304 http://registry.npmjs.org/options

Steps to reproduce

Have a dependency in npm-shrinkwrap.json which has a from containing @latest such as;

"options": {
  "version": "0.0.6",
  "from": "options@latest",
  "resolved": "file:node_shrinkwrap/options-0.0.6.tgz"
}

Software versions used

OS         : osx mavericks 
node.js    : 6.2.2
npm        : 3.10.4
shrinkpack : 0.12.5
JamieMason commented 8 years ago

@latest seems to not be relevant after all, removing all "from" entries from npm-shrinkwrap.json has no effect.

"options": {
  "version": "0.0.6",
  "resolved": "file:node_shrinkwrap/options-0.0.6.tgz"
},
JamieMason commented 8 years ago

Unable to reproduce.